Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Address some of the no_group_crossing dependencies (#198261) #199165

Merged
merged 3 commits into from
Nov 8, 2024
Merged

[8.x] Address some of the no_group_crossing dependencies (#198261) #199165

merged 3 commits into from
Nov 8, 2024

Conversation

gsoldevila
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@gsoldevila
Address some of the no_group_crossing dependencies (elastic#198261)
c91614d 
### Summary

This PR relocates some plugins and packages that are incorrectly
categorised, aiming at reducing inter-solution dependencies. It also
fixes some incorrect import statements that introduce unnecessary
dependencies with other components.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Maryam Saeidi <[email protected]>
(cherry picked from commit 730f4c9)

# Conflicts:
#	.eslintrc.js
#	src/plugins/ai_assistant_management/selection/kibana.jsonc
#	x-pack/packages/kbn-ai-assistant/kibana.jsonc
#	x-pack/plugins/dashboard_enhanced/kibana.jsonc
#	x-pack/plugins/observability_solution/observability_ai_assistant/kibana.jsonc
#	x-pack/plugins/screenshotting/kibana.jsonc
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant Team:obs-ux-management Observability Management User Experience Team labels Nov 6, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@gsoldevila gsoldevila enabled auto-merge (squash) November 6, 2024 15:38
@gsoldevila gsoldevila mentioned this pull request Nov 6, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

TinaHeiligers
TinaHeiligers approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 8, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 3252c5c
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-199165-3252c5c5c484

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
telemetryCollectionXpack 1 0 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 471.8KB 471.3KB -444.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
upgradeAssistant 24.6KB 24.6KB -46.0B
Unknown metric groups

API count

id before after diff
telemetryCollectionXpack 1 0 -1

History

@gsoldevila gsoldevila merged commit 722f758 into elastic:8.x Nov 8, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees
No one assigned
Labels
backport ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsoldevila @elasticmachine @TinaHeiligers